[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2] hw/ppc/spapr_iommu: Fix the check for invalid
|
From: |
David Gibson |
|
Subject: |
Re: [Qemu-ppc] [PATCH v2] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn |
|
Date: |
Thu, 23 Apr 2015 16:04:10 +1000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Apr 21, 2015 at 05:12:11PM +0200, Thomas Huth wrote:
> The check "liobn & 0xFFFFFFFF00000000ULL" in spapr_tce_find_by_liobn()
> is completely useless since liobn is only declared as an uint32_t
> parameter. Fix this by using target_ulong instead (this is what most
> of the callers of this function are using, too).
>
> Signed-off-by: Thomas Huth <address@hidden>
Thanks. Adjusted for a conflict with Alexey's DDW preliminaries and
applied to spapr-next.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpuWC1OberZp.pgp
Description: PGP signature