[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH v2 13/23] cpus: Add Error argument to cpu_exec
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [RFC PATCH v2 13/23] cpus: Add Error argument to cpu_exec_init() |
Date: |
Wed, 25 Mar 2015 14:12:39 +1100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Mar 23, 2015 at 07:05:54PM +0530, Bharata B Rao wrote:
> Add an Error argument to cpu_exec_init() to let users collect the
> error. Change all callers to currently pass NULL error argument. This change
> is needed for the following reasons:
>
> - A subsequent commit changes the CPU enumeration logic in cpu_exec_init()
> resulting in cpu_exec_init() to fail if cpu_index values corresponding
> to max_cpus have already been handed out.
> - There is a thinking that cpu_exec_init() should be called from realize
> rather than instance_init. With this change, those architectures
> that can move this call into realize function can do so in a phased
> manner.
>
> Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: David Gibson <address@hidden>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpMlEEH4cJyM.pgp
Description: PGP signature
- Re: [Qemu-ppc] [RFC PATCH v2 07/23] cpu: Prepare Socket container type, (continued)
- [Qemu-ppc] [RFC PATCH v2 10/23] ppc: Update cpu_model in MachineState, Bharata B Rao, 2015/03/23
- [Qemu-ppc] [RFC PATCH v2 11/23] ppc: Create sockets and cores for CPUs, Bharata B Rao, 2015/03/23
- [Qemu-ppc] [RFC PATCH v2 12/23] spapr: CPU hotplug support, Bharata B Rao, 2015/03/23
- [Qemu-ppc] [RFC PATCH v2 13/23] cpus: Add Error argument to cpu_exec_init(), Bharata B Rao, 2015/03/23
- Re: [Qemu-ppc] [RFC PATCH v2 13/23] cpus: Add Error argument to cpu_exec_init(),
David Gibson <=
- [Qemu-ppc] [RFC PATCH v2 14/23] cpus: Convert cpu_index into a bitmap, Bharata B Rao, 2015/03/23
- [Qemu-ppc] [RFC PATCH v2 16/23] cpus: Reclaim vCPU objects, Bharata B Rao, 2015/03/23
- [Qemu-ppc] [RFC PATCH v2 15/23] ppc: Move cpu_exec_init() call to realize function, Bharata B Rao, 2015/03/23
- [Qemu-ppc] [RFC PATCH v2 17/23] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if already enabled, Bharata B Rao, 2015/03/23