Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 0/2] Introduce default ram size in MachineClass

[Nikunj A Dadhania]

Markus Armbruster <address@hidden> writes:

> Nikunj A Dadhania <address@hidden> writes:
>
>> Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for
>> all machines. Introduce a default_ram_size as part of MachineClass.
>>
>> The below patches has following behaviour:
>>
>> 1) If the user does not provide "-m" option, machine's default ram
>>    size will be picked.
>>
>> 2) In case the user provides memory that is lesser than machine's
>>    default ram size, we upscale the ram_size to machine's
>>    default_ram_size. A warning is displayed for the change that qemu
>>    has done.
>
> Please do not "improve" the user's explicit order that way.  Either
> execute the order as is, or reject it as invalid.

If there is consensus for doing this, I can change the patches
accordingly.

Rejection is also change of behaviour. Because till now, a VM would
start with any memory size, even if it's less that 128MB
(default_ram_size). With rejection, all those VMs would fail booting
displaying the warning. Is this OK?

>
> So far, we've always executed this order.
>
> [...]

Regards,
Nikunj