Re: [Qemu-ppc] [PATCH v2] spapr_vio/spapr_iommu: Move VIO bypass where it belongs

[David Gibson]

On Thu, Jan 29, 2015 at 11:48:46AM +1100, Alexey Kardashevskiy wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 01/29/2015 11:31 AM, David Gibson wrote:
> > On Wed, Jan 28, 2015 at 07:49:48PM +1100, Alexey Kardashevskiy wrote:
> >> On 01/28/2015 08:21 AM, Alexey Kardashevskiy wrote:
> >>> On 01/27/2015 05:13 PM, Alexey Kardashevskiy wrote:
> > [snip]
> >>>> diff --git a/include/hw/ppc/spapr_vio.h
> >>>> b/include/hw/ppc/spapr_vio.h index 46edc2a..6ad55d1 100644 ---
> >>>> a/include/hw/ppc/spapr_vio.h +++ b/include/hw/ppc/spapr_vio.h @@
> >>>> -64,6 +64,8 @@ struct VIOsPAPRDevice { target_ulong
> >>>> signal_state; VIOsPAPR_CRQ crq; AddressSpace as; +
> >>>> MemoryRegion mrroot; +    MemoryRegion mrbypass; sPAPRTCETable
> >>>> *tcet; };
> >>>> 
> >>>> 
> >>> 
> >>> 
> >> 
> >> 
> >> I believe doing something like this is way too disguising because
> >> of tobj->parent?
> > 
> > It's kinda ugly, but it's the best way I can think of.
> 
> 
> 
> Better than having VIOsPAPRDevice pointer in sPAPRTCETable? I would
> expect a object_get_parent() helper to exist but it is not there and I
> believe this is for a reason (may be it will be get rid of some time
> later)...


Uh.. I think someone who knows qom better than me will have to answer
that..

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgp1ZWG44DWS7.pgp
Description: PGP signature