[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH] target-ppc: explicitly save page table header
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-ppc] [RFC PATCH] target-ppc: explicitly save page table headers in big endian |
|
Date: |
Mon, 03 Nov 2014 16:10:06 +0100 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 03.11.14 15:56, Cedric Le Goater wrote:
> On 11/03/2014 03:53 PM, Alexander Graf wrote:
>>
>>
>> On 27.10.14 11:23, Cédric Le Goater wrote:
>>> Currently, when the page tables are saved, the kvm_get_htab_header structs
>>> and the ptes are assumed being big endian and dumped as a indistinct blob
>>> in the statefile. This is no longer true when the host is little endian
>>> and this breaks restoration.
>>>
>>> This patch unfolds the kvmppc_save_htab routine to write explicitly the
>>> kvm_get_htab_header structs in big endian. The ptes are left untouched.
>>>
>>> Signed-off-by: Cédric Le Goater <address@hidden>
>>> Cc: address@hidden
>>> Cc: address@hidden
>>> Cc: address@hidden
>>
>> LGTM :)
>
> OK then. I will resend as a PATCH, along with the kvm kernel patch which is
> just a couple of lines. Then, we can start testing cross-endian migration !
Awesome! Looking forward to it :).
Alex