[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob |
Date: |
Fri, 29 Aug 2014 11:06:04 +1000 |
On Fri, 2014-08-29 at 02:40 +0200, Alexander Graf wrote:
>
> On 29.08.14 00:25, Benjamin Herrenschmidt wrote:
> > On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote:
> >> I strongly disagree with David. Legally there is no difference between a
> >> .bin file that contains code and an array made of instructions. And the
> >> more target code we can keep outside of QEMU the better.
> >
> > Ugh ... having a separate file with it's own build system etc... for 5
> > instructions is borderline ridiculous too :-)
>
> Then don't use it - nobody's forcing you to do so :). Just use the
> provided binary. I fail to see the difference between
>
> uint32_t rtas_blob[] = { INST_SC1, INST_BLR };
>
> and
>
> uint32_t *rtas_blob;
> load_file_from_disk(rtas_blob);
>
> except that we're using an actual assembler ;).
So you fail to see the difference with an array of 5 words vs. running
through thousands of instructions & syscall to read those same 5 words
from disk ? :-)
Cheers,
Ben.
- [Qemu-ppc] [PATCH 0/5] target-ppc: Add FWNMI support in QEMU for powerKVM guests, Aravinda Prasad, 2014/08/25
- [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob, Aravinda Prasad, 2014/08/25
- Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob, Alexander Graf, 2014/08/28
- Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob, Aravinda Prasad, 2014/08/28
- Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob, Alexander Graf, 2014/08/28
- Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob, Benjamin Herrenschmidt, 2014/08/28
- Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob, Alexander Graf, 2014/08/28
- Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob,
Benjamin Herrenschmidt <=
- Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob, Alexander Graf, 2014/08/28
- Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob, Benjamin Herrenschmidt, 2014/08/28
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob, David Gibson, 2014/08/29
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob, David Gibson, 2014/08/29
[Qemu-ppc] [PATCH 2/5] target-ppc: Register and handle HCALL to receive updated RTAS region, Aravinda Prasad, 2014/08/25
[Qemu-ppc] [PATCH 3/5] target-ppc: Build error log, Aravinda Prasad, 2014/08/25