[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [V3 PATCH 04/13] linux-user: Make ipc syscall's third argumen
From: |
Tom Musta |
Subject: |
[Qemu-ppc] [V3 PATCH 04/13] linux-user: Make ipc syscall's third argument an abi_long |
Date: |
Wed, 13 Aug 2014 14:04:39 -0500 |
For those target ABIs that use the ipc system call (e.g. POWER),
the third argument is used in the shmat path as a pointer. It
therefore must be declared as an abi_long (versus int) so that
the address bits are not lost in truncation. In fact, all arguments
to do_ipc should be declared as abit_long.
In fact, it makes more sense for all of the arguments to be declared
as abi_long (except call).
Signed-off-by: Tom Musta <address@hidden>
---
V2: Changed all do_ipc arguments (except "call") to abi_long per Peter
Maydell's review.
linux-user/syscall.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index bee1f4e..3a4f432 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -3125,8 +3125,8 @@ static inline abi_long do_shmdt(abi_ulong shmaddr)
#ifdef TARGET_NR_ipc
/* ??? This only works with linear mappings. */
/* do_ipc() must return target values and target errnos. */
-static abi_long do_ipc(unsigned int call, int first,
- int second, int third,
+static abi_long do_ipc(unsigned int call, abi_long first,
+ abi_long second, abi_long third,
abi_long ptr, abi_long fifth)
{
int version;
@@ -3148,9 +3148,9 @@ static abi_long do_ipc(unsigned int call, int first,
/* The semun argument to semctl is passed by value, so dereference the
* ptr argument. */
abi_ulong atptr;
- get_user_ual(atptr, (abi_ulong)ptr);
+ get_user_ual(atptr, ptr);
ret = do_semctl(first, second, third,
- (union target_semun)(abi_ulong) atptr);
+ (union target_semun) atptr);
break;
}
--
1.7.1
- [Qemu-ppc] [V3 PATCH 00/13] target-ppc: Linux-User Mode Bug Fixes for Power, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 01/13] linux-user: PPC64 semid_ds Doesnt Include _unused1 and _unused2, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 02/13] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 05/13] linux-user: Conditionally Pass Attribute Pointer to mq_open(), Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 03/13] linux-user: Properly Handle semun Structure In Cross-Endian Situations, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 06/13] linux-user: Detect Negative Message Sizes in msgsnd System Call, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 04/13] linux-user: Make ipc syscall's third argument an abi_long,
Tom Musta <=
- [Qemu-ppc] [V3 PATCH 08/13] linux-user: Detect fault in sched_rr_get_interval, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 07/13] linux-user: Handle NULL sched_param argument to sched_*, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 11/13] linux-user: clock_nanosleep errno Handling on PPC, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 09/13] linux-user: Move get_ppc64_abi, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 10/13] linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 13/13] linux-user: writev Partial Writes, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 12/13] linux-user: Support target-to-host translation of mlockall argument, Tom Musta, 2014/08/13
- Re: [Qemu-ppc] [Qemu-devel] [V3 PATCH 00/13] target-ppc: Linux-User Mode Bug Fixes for Power, Riku Voipio, 2014/08/14