[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v4 02/29] target-ppc: Merge 970FX and 970MP into a
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-ppc] [PATCH v4 02/29] target-ppc: Merge 970FX and 970MP into a single 970 class |
Date: |
Wed, 04 Jun 2014 14:48:41 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/04/2014 02:25 AM, Tom Musta wrote:
> On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
>> @@ -7303,8 +7304,21 @@ static void init_proc_970 (CPUPPCState *env)
>> SPR_NOACCESS, SPR_NOACCESS,
>> &spr_read_hior, &spr_write_hior,
>> 0x00000000);
>> +
>> + spr_register(env, SPR_CTRL, "SPR_CTRL",
>> + SPR_NOACCESS, SPR_NOACCESS,
>> + SPR_NOACCESS, &spr_write_generic,
>> + 0x00000000);
>> + spr_register(env, SPR_UCTRL, "SPR_UCTRL",
>> + SPR_NOACCESS, SPR_NOACCESS,
>> + &spr_read_generic, SPR_NOACCESS,
>> + 0x00000000);
>
> This doesn't look quite right .... UCTRL is readable also from both user &
> supervisor mode.
>
> And UCTRL should alias CTRL (a la your read_ureg helper).
>
> But you've only re-arranged existing code ... not regressed anything. This
> should be fixed in
> a follow up patch.
I will add it as a separate patch in v5.
--
Alexey
- [Qemu-ppc] [PATCH v4 12/29] target-ppc: Move POWER7/8 PIR/PURR/SPURR SPR registration to helpers, (continued)
- [Qemu-ppc] [PATCH v4 12/29] target-ppc: Move POWER7/8 PIR/PURR/SPURR SPR registration to helpers, Alexey Kardashevskiy, 2014/06/03
- [Qemu-ppc] [PATCH v4 07/29] target-ppc: Add PMC7/8 to 970 class, Alexey Kardashevskiy, 2014/06/03
- [Qemu-ppc] [PATCH v4 02/29] target-ppc: Merge 970FX and 970MP into a single 970 class, Alexey Kardashevskiy, 2014/06/03
- [Qemu-ppc] [PATCH v4 15/29] target-ppc: Make use of gen_spr_book3s_altivec() for POWER7/8, Alexey Kardashevskiy, 2014/06/03
- [Qemu-ppc] [PATCH v4 10/29] target-ppc: Remove check_pow_970FX, Alexey Kardashevskiy, 2014/06/03
- [Qemu-ppc] [PATCH v4 14/29] target-ppc: Move POWER7/8 CFAR/DSCR/CTRL/PPR/PCR SPR registration to helpers, Alexey Kardashevskiy, 2014/06/03
- [Qemu-ppc] [PATCH v4 09/29] target-ppc: Introduce and reuse generalized init_proc_book3s_64(), Alexey Kardashevskiy, 2014/06/03
- [Qemu-ppc] [PATCH v4 19/29] target-ppc: Add POWER7's TIR SPR, Alexey Kardashevskiy, 2014/06/03