Re: [Qemu-ppc] [Qemu-devel] [V3 PATCH 2/5] target-ppc: Allow little-endian user mode.

[Peter Maydell]

On 27 May 2014 22:34, Tom Musta <address@hidden> wrote:
> This allows running PPC64 little-endian in user mode if target is configured
> that way.  In PPC64 LE user mode we set MSR.LE during initialization.
>
> Signed-off-by: Doug Kwan <address@hidden>
> Signed-off-by: Tom Musta <address@hidden>
>
> ---
> V2: Overhaul handling of byteswapping in code generation and mem helpers.
> V3: Eliminating MSR[LE] check in user mode per Alex Graf's review.  Addressed
> checkpatch violations.

It doesn't look like this is correctly handling the endianness requirements
for the 128 bit conditional store when CONFIG_USER_ONLY is defined
(in which case it is handled mostly in linux-user/main.c, as opposed to
the translate.c code which is used for system emulation mode); or did
I miss that bit of the patch?

thanks
-- PMM