[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2] spapr: Enable dynamic change of the supported
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-ppc] [PATCH v2] spapr: Enable dynamic change of the supported hypercalls list |
Date: |
Thu, 22 May 2014 21:01:03 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/22/2014 08:47 PM, Alexander Graf wrote:
>
> On 21.05.14 17:21, Alexey Kardashevskiy wrote:
>> At the moment the "ibm,hypertas-functions" list is fixed. However some
>> calls should be listed there if they are supported by QEMU or the host
>> kernel.
>>
>> This enables hyperrtas_prop to grow on stack by adding
>> a SPAPR_HYPERRTAS_ADD macro. "qemu,hypertas-functions" is converted as well.
>>
>> The first user of this is going to be a "multi-tce" property.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>> ---
>> Changes:
>> v2:
>> * replaced alloca() with GString
>> ---
>> hw/ppc/spapr.c | 30 +++++++++++++++++++++++-------
>> 1 file changed, 23 insertions(+), 7 deletions(-)
>>
>> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
>> index 0a61246..3b28211 100644
>> --- a/hw/ppc/spapr.c
>> +++ b/hw/ppc/spapr.c
>> @@ -293,6 +293,10 @@ static size_t create_page_sizes_prop(CPUPPCState
>> *env, uint32_t *prop,
>> } \
>> } while (0)
>> +static inline void add_str(GString *s, const gchar *s1)
>
> Please remove the "inline" :). Otherwise this looks a lot nicer than before :)
Good :) What now? Have you finished with this set and I can repost it?
--
Alexey
- [Qemu-ppc] [PATCH 3/9] spapr_pci: Introduce a finish_realize() callback, (continued)
- [Qemu-ppc] [PATCH 3/9] spapr_pci: Introduce a finish_realize() callback, Alexey Kardashevskiy, 2014/05/21
- [Qemu-ppc] [PATCH 2/9] spapr_iommu: Enable multiple TCE requests, Alexey Kardashevskiy, 2014/05/21
- [Qemu-ppc] [PATCH 1/9] spapr: Enable dynamic change of the supported hypercalls list, Alexey Kardashevskiy, 2014/05/21
- [Qemu-ppc] [PATCH 7/9] spapr_iommu: Get rid of window_size in sPAPRTCETable, Alexey Kardashevskiy, 2014/05/21
- [Qemu-ppc] [PATCH 4/9] spapr_pci: spapr_iommu: Make DMA window a subregion, Alexey Kardashevskiy, 2014/05/21
- [Qemu-ppc] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable, Alexey Kardashevskiy, 2014/05/21