Re: [Qemu-ppc] [Qemu-devel] macio ide question/bug report

[BALATON Zoltan]

On Thu, 15 May 2014, BALATON Zoltan wrote:
> On Thu, 15 May 2014, BALATON Zoltan wrote:
> > confusing.) Do you think that replacing io->len in your patch with 
> > s->io_buffer_size would be the correct thing to do?
>
> Probably that's not enough. I've tried it and then it gets to here:

I should've also included these lines too to make it more clear what did I 
change:

114         if (s->packet_transfer_size && s->lba == -1) {
115             MACIO_DPRINTF("non-IO ATAPI DMA transfer size: %d\n", io->len);
non-IO ATAPI DMA transfer size: 804
117             cpu_physical_memory_write(io->addr, s->io_buffer, 
s->io_buffer_size);
118             s->packet_transfer_size -= s->io_buffer_size;
119             MACIO_DPRINTF("end of non-IO ATAPI DMA transfer\n");

> end of non-IO ATAPI DMA transfer
> 122         if (!s->packet_transfer_size) {
> (gdb) p s->packet_transfer_size
> $1 = 0
> (gdb) n
> 123             MACIO_DPRINTF("end of transfer\n");
> end of transfer
> 124             ide_atapi_cmd_ok(s);
> 125             m->dma_active = false;
> 128         if (io->len == 0) {
> (gdb) p io->len
> $2 = 804
> (gdb) l
> 123             MACIO_DPRINTF("end of transfer\n");
> 124             ide_atapi_cmd_ok(s);
> 125             m->dma_active = false;
> 126         }
> 127
> 128         if (io->len == 0) {
> 129             MACIO_DPRINTF("end of DMA\n");
> 130             goto done;
> 131         }
> 132
> 133         /* launch next transfer */
> 134
> 135	    /* handle unaligned accesses first, get them over with and only 
> do the
> 136            remaining bulk transfer using our async DMA helpers */
> 137         unaligned = io->len & 0x1ff;
> 138         if (unaligned) {
> 139             int sector_num = (s->lba << 2) + (s->io_buffer_index >> 9);
> 140             int nsector = io->len >> 9;
> 141
> 142	        MACIO_DPRINTF("precopying unaligned %d bytes to %#" 
> HWADDR_PRIx "\n",
> (gdb) c
> Continuing.
> precopying unaligned 292 bytes to 0xe4f50c
> io->len = 0x200
> set remainder to: -20
> sector_num=-4 size=0, cmd_cmd=0
> atapi_cmd_error: sense=0x5 asc=0x21
> done DMA
> DBDMA: dbdma_end
>
> Regards,
> BALATON Zoltan