|
From: | Alexander Graf |
Subject: | Re: [Qemu-ppc] [PATCH 2/3] PPC: Allow little-endian user mode. |
Date: | Thu, 08 May 2014 11:11:46 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130910 Thunderbird/17.0.9 |
On 05/08/2014 11:05 AM, Doug Kwan (關振德) wrote:
There are a few places where we do 128-bit loads/store. We need to swap the high/low halves and also do byteswap for each half. Byteswap of each half is handled differently depending on TARGET_WORDS_BIGENDIAN but the swapping of high/low halves is always controlled by msr.le. Would our intention be clearer if defined another function swap_high_low_64_bits() instead of msr.le?
This is my last warning about top posting. One more top post and I will ignore any future email from you.
The explanation makes a lot of sense. This probably just deserves a quick comment in the code so that nobody stumbles over this when he looks at it :).
Alex
[Prev in Thread] | Current Thread | [Next in Thread] |