Re: [Qemu-ppc] [PATCH] mac99: Bring memory layout closer to real hardware

[Alexander Graf]

On 16.04.14 12:24, BALATON Zoltan wrote:
> On Tue, 15 Apr 2014, Alexander Graf wrote:
> > Try to do the same with the _E macro. Be creative :)
>
> This one did it:
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index e3fcb03..d1e175e 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -10341,7 +10341,7 @@ GEN_HANDLER(stop##u, opc, 0xFF, 0xFF, 
> 0x00000000, type),
>  #define GEN_STUX(name, stop, opc2, opc3, 
> type)                                \
>  GEN_HANDLER(name##ux, 0x1F, opc2, opc3, 0x00000001, type),
>  #define GEN_STX_E(name, stop, opc2, opc3, type, 
> type2)                        \
> -GEN_HANDLER_E(name##x, 0x1F, opc2, opc3, 0x00000001, type, type2),
> +GEN_HANDLER_E(name##x, 0x1F, opc2, opc3, 0x00000000, type, type2),
>  #define GEN_STS(name, stop, op, 
> type)                                         \
>  GEN_ST(name, stop, op | 0x20, 
> type)                                           \
>  GEN_STU(name, stop, op | 0x21, 
> type)                                          \

Cool. Could you please write a small program similar to the one I sent 
you that runs all of these instructions and checks that really none of 
them trigger a program interrupt on real hardware? We can then remove 
the reserved 1 bit from the mask.


Alex