[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 26/29] dump-guest-memory: Check for the correct return
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PULL 26/29] dump-guest-memory: Check for the correct return value |
Date: |
Fri, 25 Oct 2013 23:27:51 +0200 |
From: "Aneesh Kumar K.V" <address@hidden>
We should check for error with s->note_size
Signed-off-by: Aneesh Kumar K.V <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dump.c b/dump.c
index 846155c..80a9116 100644
--- a/dump.c
+++ b/dump.c
@@ -66,7 +66,7 @@ typedef struct DumpState {
uint32_t sh_info;
bool have_section;
bool resume;
- size_t note_size;
+ ssize_t note_size;
hwaddr memory_offset;
int fd;
@@ -765,7 +765,7 @@ static int dump_init(DumpState *s, int fd, bool paging,
bool has_filter,
s->note_size = cpu_get_note_size(s->dump_info.d_class,
s->dump_info.d_machine, nr_cpus);
- if (ret < 0) {
+ if (s->note_size < 0) {
error_set(errp, QERR_UNSUPPORTED);
goto cleanup;
}
--
1.8.1.4
- [Qemu-ppc] [PULL 22/29] spapr-pci: enable irqfd for INTx, (continued)
- [Qemu-ppc] [PULL 22/29] spapr-pci: enable irqfd for INTx, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 09/29] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 13/29] xics: add pre_save/post_load dispatchers, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 14/29] xics: convert init() to realize(), Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 18/29] xics-kvm: Support for in-kernel XICS interrupt controller, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 17/29] xics: add cpu_setup callback, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 16/29] xics: split to xics and xics-common, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 23/29] target-ppc: Update slb array with correct index values., Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 06/29] spapr: increase temporary fdt buffer size, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 25/29] target-ppc: Use #define for max slb entries, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 26/29] dump-guest-memory: Check for the correct return value,
Alexander Graf <=
- [Qemu-ppc] [PULL 24/29] target-ppc: Check for error on address translation in memsave command, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 29/29] spapr: Use DeviceClass::fw_name for device tree CPU node, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 28/29] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families, Alexander Graf, 2013/10/25
- [Qemu-ppc] [PULL 27/29] target-ppc: dump-guest-memory support, Alexander Graf, 2013/10/25
- Re: [Qemu-ppc] [PULL 00/29] ppc patch queue 2013-10-25, Mark Cave-Ayland, 2013/10/25
- [Qemu-ppc] [PULL 01/29] pseries: Update SLOF firmware image, Alexander Graf, 2013/10/25