[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 11/13] Add xxsel
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 11/13] Add xxsel |
|
Date: |
Wed, 09 Oct 2013 13:13:13 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
On 10/04/2013 06:24 AM, Tom Musta wrote:
> + tcg_gen_and_i64(b, b, c);
> + tcg_gen_not_i64(c, c);
> + tcg_gen_and_i64(a, a, c);
tcg_gen_andc_i64.
> +#define GEN_XXSEL() \
> +GEN_XXSEL_ROW(0x00) \
> +GEN_XXSEL_ROW(0x01) \
Why bother with defining GEN_XXSEL when its only used once?
Surely just put the rows there.
OTOH, this does suggest that we could do with a better way
to decode the instructions, because this is ugly...
r~
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 04/13] Add lxvw4x, (continued)
- [Qemu-ppc] [PATCH 05/13] Add stxsdx, Tom Musta, 2013/10/04
- [Qemu-ppc] [PATCH 06/13] Add stxvw4x, Tom Musta, 2013/10/04
- [Qemu-ppc] [PATCH 07/13] Add VSX Scalar Move Instructions, Tom Musta, 2013/10/04
- [Qemu-ppc] [PATCH 08/13] Add VSX Vector Move Instructions, Tom Musta, 2013/10/04
- [Qemu-ppc] [PATCH 09/13] Add Power7 VSX Logical Instructions, Tom Musta, 2013/10/04
- [Qemu-ppc] [PATCH 10/13] Add xxmrgh/xxmrgl, Tom Musta, 2013/10/04
- [Qemu-ppc] [PATCH 11/13] Add xxsel, Tom Musta, 2013/10/04
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 11/13] Add xxsel,
Richard Henderson <=
- [Qemu-ppc] [PATCH 12/13] Add xxspltw, Tom Musta, 2013/10/04
- [Qemu-ppc] [PATCH 13/13] Add xxsldwi, Tom Musta, 2013/10/04