[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 01/10] prep: kill get_system_io() usage
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-ppc] [PATCH v2 01/10] prep: kill get_system_io() usage |
Date: |
Wed, 04 Sep 2013 08:13:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 04/09/2013 00:29, Hervé Poussineau ha scritto:
> While ISA address space in prep machine is currently the one returned
> by get_system_io(), this depends of the implementation of i82378/raven
> devices, and this may not be the case forever.
>
> Use the right ISA address space when adding some more ports to it.
> We can use whatever ISA device on the right ISA bus, as all ISA devices
> on the same ISA bus share the same ISA address space.
>
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
> hw/ppc/prep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> index 7e04b1a..efc892d 100644
> --- a/hw/ppc/prep.c
> +++ b/hw/ppc/prep.c
> @@ -656,7 +656,7 @@ static void ppc_prep_init(QEMUMachineInitArgs *args)
> sysctrl->reset_irq = cpu->env.irq_inputs[PPC6xx_INPUT_HRESET];
>
> portio_list_init(port_list, NULL, prep_portio_list, sysctrl, "prep");
> - portio_list_add(port_list, get_system_io(), 0x0);
> + portio_list_add(port_list, isa_address_space_io(isa), 0x0);
>
> /* PowerPC control and status register group */
> #if 0
>
Should it be instead the I/O address space of the Raven instead
(pci_bus->address_space_io, or alternatively you could add a new
function)? Or if you make it the ISA address space, should this be a
new, full-blown ISA device?
Paolo
- [Qemu-ppc] [PATCH v2 00/10] prep: improve Raven PCI host emulation, Hervé Poussineau, 2013/09/03
- [Qemu-ppc] [PATCH v2 02/10] raven: use constant PCI_NUM_PINS instead of 4, Hervé Poussineau, 2013/09/03
- [Qemu-ppc] [PATCH v2 01/10] prep: kill get_system_io() usage, Hervé Poussineau, 2013/09/03
- Re: [Qemu-ppc] [PATCH v2 01/10] prep: kill get_system_io() usage,
Paolo Bonzini <=
- [Qemu-ppc] [PATCH v2 03/10] raven: move BIOS loading from board code to PCI host, Hervé Poussineau, 2013/09/03
- [Qemu-ppc] [PATCH v2 04/10] raven: rename intack region to pci_intack, Hervé Poussineau, 2013/09/03
- [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory region, Hervé Poussineau, 2013/09/03
- Re: [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory region, Paolo Bonzini, 2013/09/04
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 05/10] raven: set a correct PCI I/O memory region, Peter Maydell, 2013/09/04
- Re: [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory region, Paolo Bonzini, 2013/09/04
- Re: [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory region, Peter Maydell, 2013/09/04
- Re: [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory region, Paolo Bonzini, 2013/09/04
- Re: [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory region, Peter Maydell, 2013/09/04