Re: [Qemu-ppc] [RFC PATCH] spapr-vscsi: add task management

[Alexey Kardashevskiy]

On 07/22/2013 10:23 AM, Benjamin Herrenschmidt wrote:
> On Mon, 2013-07-22 at 10:20 +1000, Alexey Kardashevskiy wrote:
>> May be. But there was no way to get this callback called till I started
>> calling scsi_req_cancel in this patch so I would not split.
> 
> You probably still should. The smaller each individual patch, the better
> (in part because that makes them easier to review).


Should make it easier but in fact it does not for me :)


> So a first patch adding the new callback, then a second patch adding the
> task management.

I can even add tasks one-by-one :)

Come on, is this patch really big or even close to be called big?


-- 
Alexey