[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 01/12] chardev: ringbuf: add optional
From: |
Eric Blake |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 01/12] chardev: ringbuf: add optional save parameter to save state |
Date: |
Thu, 20 Jun 2013 20:49:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 06/19/2013 09:40 PM, Anthony Liguori wrote:
> It is very useful to use the ringbuf chardev for writing test
> cases and even more useful if the state of the ringbuf is migrated
> with the guest. Otherwise it's hard to detect data loss in a test
> case.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
> qapi-schema.json | 3 ++-
> qemu-char.c | 45 +++++++++++++++++++++++++++++++++++++++++++--
> 2 files changed, 45 insertions(+), 3 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index a80ee40..90602d1 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3280,10 +3280,11 @@
> # Configuration info for memory chardevs
> #
> # @size: #optional Ringbuffer size, must be power of two, default is 65536
> +# @save: #optional Register a savevm handler, default false
Useful to have a '(since 1.6)' notation on the added field.
> #
> # Since: 1.5
> ##
> -{ 'type': 'ChardevMemory', 'data': { '*size' : 'int' } }
> +{ 'type': 'ChardevMemory', 'data': { '*size' : 'int', '*save': 'bool' } }
Yet another case for introspection discovering an added feature to an
existing command.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-ppc] [PATCH 00/12] spapr: add qtest support and refactor vty, Anthony Liguori, 2013/06/19
- [Qemu-ppc] [PATCH 01/12] chardev: ringbuf: add optional save parameter to save state, Anthony Liguori, 2013/06/19
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 01/12] chardev: ringbuf: add optional save parameter to save state,
Eric Blake <=
- [Qemu-ppc] [PATCH 03/12] qtest: return string from QMP commands, Anthony Liguori, 2013/06/19
- [Qemu-ppc] [PATCH 06/12] spapr-vty: add copyright and license, Anthony Liguori, 2013/06/19
- Re: [Qemu-ppc] [PATCH 06/12] spapr-vty: add copyright and license, Michael Ellerman, 2013/06/19
- Re: [Qemu-ppc] [PATCH 06/12] spapr-vty: add copyright and license, Alexey Kardashevskiy, 2013/06/20
- Re: [Qemu-ppc] [PATCH 06/12] spapr-vty: add copyright and license, David Gibson, 2013/06/20
- Re: [Qemu-ppc] [PATCH 06/12] spapr-vty: add copyright and license, Paolo Bonzini, 2013/06/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 06/12] spapr-vty: add copyright and license, Andreas Färber, 2013/06/20
- [Qemu-ppc] [PATCH 09/12] spapr-vio: move special case handling for reg=0 to vio, Anthony Liguori, 2013/06/19