[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessar
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu() |
Date: |
Fri, 10 May 2013 15:42:05 +0100 |
On 10 May 2013 15:39, Andreas Färber <address@hidden> wrote:
> A transition from CPUPPCState to PowerPCCPU can be considered safe,
> just like PowerPCCPU::env access in the opposite direction.
>
> This should slightly improve interrupt performance.
> static inline PowerPCCPU *ppc_env_get_cpu(CPUPPCState *env)
> {
> - return POWERPC_CPU(container_of(env, PowerPCCPU, env));
> + return container_of(env, PowerPCCPU, env);
> }
So if this is worthwhile shouldn't we be doing it for
all our CPUs?
thanks
-- PMM