[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of PPC64 rldcl insn
From: |
Alexander Graf |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of PPC64 rldcl insn |
Date: |
Tue, 7 May 2013 00:14:47 +0200 |
On 06.05.2013, at 20:13, Torbjorn Granlund wrote:
> Alexander Graf <address@hidden> writes:
>
> Thanks a lot for the bug report and test case! Please CC qemu-ppc
> whenever you find issues or have patches for PPC. That makes filtering
> for important mails a lot easier.
>
> Would that make my complaints be considered more or less important? :-)
>
> Does the patch below fix the issue for you?
>
> It indeed does. (I actually tried that already, but I cannot follow the
> data flow into these functions, so cannot tell if that patch is
> sufficient.
Yes, it is. It's a leftover bug from converting the code to TCG I assume.
> This bug indicates complete non-testing status of these
> insns, which are mainstream enough to be generated by gcc. I suppose
> there will likely be more such fundamental errors if more instructions
> are also completely untested.)
There's a certain chance that happens, yes. We don't have instruction test
suites for the PPC target.
Alex
- Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of PPC64 rldcl insn, Alexander Graf, 2013/05/06
- Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of PPC64 rldcl insn, Torbjorn Granlund, 2013/05/06
- Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of PPC64 rldcl insn,
Alexander Graf <=
- Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of PPC64 rldcl insn, Aurelien Jarno, 2013/05/06
- [Qemu-ppc] Incorrect handling of more PPC64 insns, Torbjorn Granlund, 2013/05/07
- Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of more PPC64 insns, Peter Maydell, 2013/05/07
- Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of more PPC64 insns, Torbjorn Granlund, 2013/05/07
- Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of more PPC64 insns, Peter Maydell, 2013/05/07
- Re: [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH), Torbjorn Granlund, 2013/05/07
- Re: [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH), Alexander Graf, 2013/05/07
- Re: [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH), Torbjorn Granlund, 2013/05/07
- Re: [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH), Torbjorn Granlund, 2013/05/07
- Re: [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH), Alexander Graf, 2013/05/07