Re: [Qemu-ppc] [Qemu-devel] [PATCH 7/7] prep: QOM'ify System I/O

[Andreas Färber]

Am 02.05.2013 22:09, schrieb Hervé Poussineau:
> Most of the functionality is extracted from hw/ppc/prep.c.
> Also add support for board identification/equipment registers.
> 
> Document it for the IBM 43p emulation.
> 
> Cc: Julio Guerra <address@hidden>
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
>  docs/ibm_43p.cfg       |    5 +
>  hw/ppc/Makefile.objs   |    1 +
>  hw/ppc/prep_systemio.c |  298 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  trace-events           |    4 +
>  4 files changed, 308 insertions(+)
>  create mode 100644 hw/ppc/prep_systemio.c

Haven't reviewed the full patch yet, but since this is not modifying
hw/ppc/prep.c, it is duplicating code rather than QOM'ifying the
existing code.

Have you looked into Julio's patch whom you CC? I'm still not sure how
to solve things for 1.5 (and this series a consider -next).

Regards,
Andreas