[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH ppc-next] target-ppc: Move CPU aliases out of tran
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-ppc] [PATCH ppc-next] target-ppc: Move CPU aliases out of translate.c |
|
Date: |
Mon, 25 Feb 2013 14:44:42 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 |
Am 25.02.2013 14:25, schrieb Alexander Graf:
>
> On 23.02.2013, at 19:20, Andreas Färber wrote:
>
>> Move array of CPU aliases to cpu-models.c, alongside model definitions.
>> This requires to zero-terminate the aliases array since ARRAY_SIZE() can
>> no longer be used in translate_init.c then.
>>
>> Suggested-by: Alexander Graf <address@hidden>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>> target-ppc/cpu-models.c | 193 +++++++++++++++++++++++++++++++++++++++++
>> target-ppc/cpu-models.h | 14 +++
>> target-ppc/translate_init.c | 201
>> +------------------------------------------
>> 3 Dateien geändert, 210 Zeilen hinzugefügt(+), 198 Zeilen entfernt(-)
>>
>> diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c
>> index 66408c0..ec30d9b 100644
>> --- a/target-ppc/cpu-models.c
>> +++ b/target-ppc/cpu-models.c
[...]
>> + { "default", "ppc" },
>
> NULL. Otherwise your checks below fail / access unknown memory.
D'oh, v2 sent...
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg