Re: [Qemu-ppc] [Qemu-devel] [PATCH 14/19] openpic: convert to qdev

[Scott Wood]

On 12/08/2012 07:44:37 AM, Alexander Graf wrote:
> This patch converts the OpenPIC device to qdev. Along the way it
> renames the "openpic" target to "raven" and the "mpic" target to
> "mpc8544", to better reflect the actual models they implement.
>
> This way we have a generic OpenPIC device now that can handle
> different flavors of the OpenPIC specification.

I'd rather not see the expansion of "mpc8544" hardcoding, especially  
since it's not really modelling an MPIC as found in an mpc8544, but  
rather half-implementing a generic Freescale MPIC.  Can we just call it  
a Freescale MPIC, and then work on parameterizing it properly (starting  
with MPIC version)?

-Scott