[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel][PATCH v5 4/4] spapr: Add support for -vga op
From: |
Andreas Färber |
Subject: |
Re: [Qemu-ppc] [Qemu-devel][PATCH v5 4/4] spapr: Add support for -vga option |
Date: |
Fri, 06 Jul 2012 15:58:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120601 Thunderbird/13.0 |
Am 06.07.2012 15:50, schrieb Alexander Graf:
>
> On 02.07.2012, at 07:25, address@hidden wrote:
>
>> @@ -712,6 +730,11 @@ static void ppc_spapr_init(ram_addr_t ram_size,
>> spapr_vscsi_create(spapr->vio_bus);
>> }
>>
>> + /* Graphics */
>> + if (spapr_vga_init(QLIST_FIRST(&spapr->phbs)->host_state.bus)) {
>> + spapr_has_graphics = true;
>> + }
>
> How about
>
> spapr_has_graphics = spapr_vga_init(...);
>
> If that gets you above 80 characters, just shove the parameter to
> spapr_vga_init into a variable.
Further, that expression could use
PCIHostState *phb = PCI_HOST_BRIDGE(QLIST_FIRST(&spapr->phbs));
spapr_vga_init(phb->bus)
once introduced through the pci_host series. :)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-ppc] [Qemu-devel][PATCH v5 0/4] Add USB option and enable vga on spapr, zhlcindy, 2012/07/02
- [Qemu-ppc] [Qemu-devel][PATCH v5 3/4] Cleanup pc.h on other platforms, zhlcindy, 2012/07/02
- [Qemu-ppc] [Qemu-devel][PATCH v5 1/4] Add usb option in machine options, zhlcindy, 2012/07/02
- Re: [Qemu-ppc] [Qemu-devel][PATCH v5 1/4] Add usb option in machine options, Alexander Graf, 2012/07/06
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 1/4] Add usb option in machine options, Andreas Färber, 2012/07/06
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 1/4] Add usb option in machine options, Alexander Graf, 2012/07/06
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 1/4] Add usb option in machine options, Andreas Färber, 2012/07/06
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 1/4] Add usb option in machine options, Li Zhang, 2012/07/08
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 1/4] Add usb option in machine options, Alexander Graf, 2012/07/08