[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 15/25] PPC: e500: dt: create /soc8544 node dynamic
From: |
Scott Wood |
Subject: |
Re: [Qemu-ppc] [PATCH 15/25] PPC: e500: dt: create /soc8544 node dynamically |
Date: |
Thu, 31 May 2012 16:58:49 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 05/30/2012 06:00 AM, Alexander Graf wrote:
> @@ -179,6 +182,20 @@ static int mpc8544_load_device_tree(CPUPPCState *env,
> }
> }
>
> + /* XXX These should go into their respective devices' code */
> + sprintf(soc, "/address@hidden", MPC8544_CCSRBAR_BASE);
This should just be "/address@hidden" (something like "address@hidden" or
"address@hidden"
would be better, but hasn't really caught on yet). "soc8544"-type names
have been discouraged for a while now.
> + qemu_devtree_setprop_string(fdt, soc, "compatible", "simple-bus");
It should also have a compatible of "fsl,mpc8544-immr".
> + qemu_devtree_setprop_cell2(fdt, soc, "reg", MPC8544_CCSRBAR_BASE,
> + MPC8544_CCSRBAR_REGSIZE);
We don't need reg here anymore.
I realize this was probably meant to produce the same output as the
current device tree, but if we're introducing new code to generate this
stuff we should follow current best practices.
-Scott
- [Qemu-ppc] [PATCH 13/25] PPC: e500: dt: create / node dynamically, (continued)
- [Qemu-ppc] [PATCH 13/25] PPC: e500: dt: create / node dynamically, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 02/25] dt: add helpers for 2, 3 and 4 cell adds, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 12/25] PPC: e500: dt: create /hypervisor node dynamically, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 24/25] PPC: e500: enable manual loading of dtb blob, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 14/25] PPC: e500: dt: create /chosen node dynamically, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 22/25] PPC: e500: dt: use 64bit cell helper, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 15/25] PPC: e500: dt: create /soc8544 node dynamically, Alexander Graf, 2012/05/30
- Re: [Qemu-ppc] [PATCH 15/25] PPC: e500: dt: create /soc8544 node dynamically,
Scott Wood <=
- [Qemu-ppc] [PATCH 20/25] PPC: e500: dt: start with empty device tree, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 07/25] dt: add helper for phandle allocation, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 11/25] PPC: e500: dt: create /cpus node dynamically, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 18/25] PPC: e500: dt: create global-utils node dynamically, Alexander Graf, 2012/05/30
- [Qemu-ppc] [PATCH 23/25] PPC: e500: dt: use target_phys_addr_t for ramsize, Alexander Graf, 2012/05/30