[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback |
Date: |
Wed, 30 May 2012 10:28:14 +0100 |
On 23 May 2012 04:08, Andreas Färber <address@hidden> wrote:
> +void cpu_tlb_flush(CPUState *cpu, bool flush_global)
> +{
> + CPUClass *cc = CPU_GET_CLASS(cpu);
> +
> + g_assert(cc->tlb_flush != NULL);
> +
> + cc->tlb_flush(cpu, flush_global);
> +}
This needs to be able to call tlb_flush() itself
rather than having to have every single subclass of CPUState
implement an identical tlb_flush method. You could do this
if there was a CPU_GET_ENV()...
> 16 files changed, 173 insertions(+), 0 deletions(-)
...which is a lot of extra code to be inserting to do nothing
that's specific to a particular target.
-- PMM
- [Qemu-ppc] [PATCH qom-next 40/59] spapr: Pass PowerPCCPU to spapr_hypercall(), (continued)
- [Qemu-ppc] [PATCH qom-next 40/59] spapr: Pass PowerPCCPU to spapr_hypercall(), Andreas Färber, 2012/05/22
- [Qemu-ppc] [PATCH qom-next 39/59] target-ppc: Pass PowerPCCPU to cpu_ppc_hypercall, Andreas Färber, 2012/05/22
- [Qemu-ppc] [PATCH qom-next 38/59] target-ppc: Pass PowerPCCPU to powerpc_excp(), Andreas Färber, 2012/05/23
- [Qemu-ppc] [PATCH qom-next 34/59] cpus: Pass CPUState to qemu_cpu_kick(), Andreas Färber, 2012/05/23
- [Qemu-ppc] [PATCH qom-next 59/59] cpu: Move halted and interrupt_request to CPUState, Andreas Färber, 2012/05/23
- [Qemu-ppc] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback, Andreas Färber, 2012/05/23
- Re: [Qemu-ppc] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback,
Peter Maydell <=
[Qemu-ppc] [PATCH qom-next 43/59] cpus: Pass CPUState to [qemu_]cpu_has_work(), Andreas Färber, 2012/05/23
Re: [Qemu-ppc] [PATCH qom-next 00/59] QOM CPUState, part 4: CPU_COMMON, Stefano Stabellini, 2012/05/23
Re: [Qemu-ppc] [Qemu-devel] [PATCH qom-next 00/59] QOM CPUState, part 4: CPU_COMMON, Andreas Färber, 2012/05/23
Re: [Qemu-ppc] [PATCH qom-next 00/59] QOM CPUState, part 4: CPU_COMMON, Blue Swirl, 2012/05/23