Re: [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

[malc]

On Tue, 8 May 2012, Andreas F?rber wrote:

> Am 08.05.2012 19:39, schrieb malc:
> > On Tue, 8 May 2012, Alexander Graf wrote:
> > 
> >>
> >> On 07.05.2012, at 01:46, Andreas F?rber wrote:
> >>
> >>> Hello malc,
> >>>
> >>> This series fixes two long-standing issues on Darwin/ppc and, based on 
> >>> your
> >>> second patch, fixes the AREG0 mode for Linux and Darwin and thus the ppc 
> >>> build.
> >>>
> >>> Compared to your last patch I have tried to avoid the { int ir; } block, 
> >>> and
> >>> I've combined both modes in one code path using ir and a new macro to 
> >>> handle
> >>> the alignment differences in a more explicit way.
> >>>
> >>> Tested on Linux and Darwin, using i386 and x86_64 (non-AREG0) as well as 
> >>> sparc
> >>> and sparc64 (AREG0). On Darwin I observed a reproducible hang in fsck 
> >>> during
> >>> INIT under Debian/sparc, which given the lateness and now unified code 
> >>> paths
> >>> (i.e., Haiku/i386 and HelenOS/sparc64 working) I'd attribute to lingering
> >>> main loop / signal handling issues.
> >>>
> >>> Regards,
> >>> Andreas
> >>>
> >>> Cc: malc <address@hidden>
> >>
> >> Malc, ping? :)
> > 
> > I raised my minor objections to Andreas on IRC, they are not yet
> > addressed.
> 
> Do you have any better suggestion based on the gcc output you requested?
> Should I rather replace all #ifdef _CALL_DARWIN with #if defined
> _CALL_DARWIN || defined __APPLE__, as seen in tcg-target.h?
> 

I'd like to understand what's going on and why, as for why i don't like
<under some condition> #define _CALL_DARWIN is that it defines something
with a reserved name, replacing all instances of _CALL_DARWIN with
<something> and using that instead is better.

-- 
mailto:address@hidden