Re: [Qemu-ppc] [PATCH] ppce500_spin: Replace assert by hw_error (fixes compiler warning)

[Stefan Weil]

Am 30.04.2012 10:54, schrieb Alexander Graf:
> On 28.04.2012, at 17:52, Stefan Weil wrote:
> > The default case in function spin_read should never be reached, 
> > therefore the old code used assert(0) to abort QEMU. This does not 
> > work when QEMU is compiled with macro NDEBUG defined. In this case 
> > (and also when the compiler does not know that assert never returns), 
> > there is a compiler warning because of the missing return value. 
> > Using hw_error allows an improved error message and aborts always. 
> > Signed-off-by: Stefan Weil <address@hidden> 
> Thanks, applied to ppc-next. The patch didn't show up on patchworks 
> btw, not sure what went wrong there. Alex

http://patchwork.ozlabs.org/patch/155666/
Did you filter on state "new"? I update the state for my patches.

Are you planning to send a pull request for QEMU 1.1?
I'd like to have this compiler warning fixed in the new version.

Regards,
Stefan