Re: [Qemu-ppc] [Qemu-devel] [PATCH 03/20] ppc: avoid AREG0 for FPU and SPE helpers

[Andreas Färber]

Am 16.04.2012 18:27, schrieb Alexander Graf:
> 
> On 31.03.2012, at 18:26, Blue Swirl wrote:
> 
>> Add an explicit CPUPPCState parameter instead of relying on AREG0.
>>
>> Signed-off-by: Blue Swirl <address@hidden>
>> ---
>> Makefile.target         |    3 -
>> target-ppc/fpu_helper.c |  350 
>> ++++++++++++++++++++++++-----------------------
>> target-ppc/helper.h     |  204 ++++++++++++++--------------
>> target-ppc/translate.c  |  106 ++++++++-------
>> 4 files changed, 339 insertions(+), 324 deletions(-)
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 34ac9d1..898cdd4 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -117,9 +117,6 @@ $(libobj-y): $(GENERATED_HEADERS)
>> ifneq ($(TARGET_BASE_ARCH), sparc)
>> op_helper.o: QEMU_CFLAGS += $(HELPER_CFLAGS)
>> endif
>> -ifeq ($(TARGET_BASE_ARCH), ppc)
>> -fpu_helper.o: QEMU_CFLAGS += $(HELPER_CFLAGS)
>> -endif
> 
> Huh?

Thought I'd leave some goodies for you. ;)

Seriously, you can compare the recent sparc and alpha conversions that
were applied. Apparently once the implicit env is gone, some flags can
or must be dropped...

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg