[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size |
Date: |
Sat, 21 Jan 2012 05:15:29 +0100 |
When setting a TLB entry, we need to check if the TLB we're putting it in
actually supports the given size. According to the 2.06 PowerPC ISA, a
value that's out of range can either be redefined to something implementation
dependent or we can raise an illegal opcode exception. We do the latter.
Signed-off-by: Alexander Graf <address@hidden>
---
v1 -> v2:
- fix min/max check
- use mav 2.0 prepared code
- raise exception on invalid page size
---
target-ppc/op_helper.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c
index 6339c95..2c8a96f 100644
--- a/target-ppc/op_helper.c
+++ b/target-ppc/op_helper.c
@@ -4228,6 +4228,7 @@ void helper_booke206_tlbwe(void)
{
uint32_t tlbncfg, tlbn;
ppcmas_tlb_t *tlb;
+ uint32_t size_tlb, size_ps;
switch (env->spr[SPR_BOOKE_MAS0] & MAS0_WQ_MASK) {
case MAS0_WQ_ALWAYS:
@@ -4273,6 +4274,16 @@ void helper_booke206_tlbwe(void)
tlb->mas1 &= ~MAS1_IPROT;
}
+ /* check that we support the targeted size */
+ size_tlb = (tlb->mas1 & MAS1_TSIZE_MASK) >> MAS1_TSIZE_SHIFT;
+ size_ps = booke206_tlbnps(env, tlbn);
+ if ((tlb->mas1 & MAS1_VALID) && (tlbncfg & TLBnCFG_AVAIL) &&
+ !(size_ps & (1 << size_tlb))) {
+ helper_raise_exception_err(POWERPC_EXCP_PROGRAM,
+ POWERPC_EXCP_INVAL |
+ POWERPC_EXCP_INVAL_INVAL);
+ }
+
if (booke206_tlb_to_page_size(env, tlb) == TARGET_PAGE_SIZE) {
tlb_flush_page(env, tlb->mas2 & MAS2_EPN_MASK);
} else {
--
1.6.0.2
- [Qemu-ppc] [PATCH 0/8] Make -cpu e500mc useful in TCG v2, Alexander Graf, 2012/01/20
- [Qemu-ppc] [PATCH 8/8] PPC: booke206: Implement tlbilx, Alexander Graf, 2012/01/20
- [Qemu-ppc] [PATCH 4/8] PPC: rename msync to msync_4xx, Alexander Graf, 2012/01/20
- [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size,
Alexander Graf <=
- Re: [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size, Scott Wood, 2012/01/23
- Re: [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size, Alexander Graf, 2012/01/23
- Re: [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size, Scott Wood, 2012/01/23
- Re: [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size, Alexander Graf, 2012/01/23
- Re: [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size, Scott Wood, 2012/01/23
- Re: [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size, Alexander Graf, 2012/01/23
- Re: [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size, Scott Wood, 2012/01/23
- Re: [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size, Alexander Graf, 2012/01/23
- Re: [Qemu-ppc] [PATCH 7/8] PPC: booke206: Check for min/max TLB entry size, Scott Wood, 2012/01/23
[Qemu-ppc] [PATCH 6/8] PPC: booke: add tlbnps handling, Alexander Graf, 2012/01/20