Re: [Qemu-ppc] [PATCH v3 3/8] prep_pci: Update I/O to MemoryRegion ops

[Avi Kivity]

On 01/13/2012 05:09 AM, Andreas Färber wrote:
> Convert to new-style read/write callbacks.
>
>  
> -static uint32_t PPC_PCIIO_readl (void *opaque, target_phys_addr_t addr)
> +static uint64_t ppc_pci_io_read(void *opaque, target_phys_addr_t addr,
> +                                unsigned int size)
>  {
>      PREPPCIState *s = opaque;
> -    uint32_t val;
> -    val = pci_data_read(s->bus, PPC_PCIIO_config(addr), 4);
> -    return val;
> +    switch (size) {
> +    case 1:
> +    case 2:
> +    case 4:
> +        return pci_data_read(s->bus, PPC_PCIIO_config(addr), size);
> +    default:
> +        abort();
> +    }
>  }

Huh? just call pci_data_read() unconditionally.

-- 
error compiling committee.c: too many arguments to function