Re: [Qemu-ppc] [Qemu-devel] [PATCH] pseries: Fix array overrun bug in PCI code

[Alexander Graf]

On 05.12.2011, at 21:24, andrzej zaborowski wrote:

> On 29 November 2011 08:41, David Gibson <address@hidden> wrote:
>> On Tue, Nov 29, 2011 at 05:21:39PM +1100, David Gibson wrote:
>>> spapr_populate_pci_devices() containd a loop with PCI_NUM_REGIONS (7)
>>> iterations.  However this overruns the 'bars' global array, which only has
>>> 6 elements. In fact we only want to run this loop for things listed in the
>>> bars array, so this patch corrects the loop bounds to reflect that.
>>> 
>>> Signed-off-by: David Gibson <address@hidden>
>> 
>> As a bugfix for a bad memory access, this is definitely for 1.0
> 
> Now applied.  Indeed it would probably have been better done before the 
> release.

Well, that's why we aligned to have 1.0.1 around christmas - because there will 
be more issues exposed soon, I'm fairly sure :)

Thanks for applying btw.


Alex