Re: [Qemu-ppc] [PATCH] pseries: Fix qdev.id handling in the VIO bus code

[Alexander Graf]

On 16.11.2011, at 06:25, David Gibson wrote:

> On Wed, Nov 16, 2011 at 03:53:13PM +1100, David Gibson wrote:
>> From: Michael Ellerman <address@hidden>
>> 
>> When the user creates a device on the command line with -device, they
>> can specify the id, using id=foo. Currently the VIO bus code overwrites
>> this id with it's own value. We should only set qdev.id if it is not
>> already set by the user.
>> 
>> The device tree code uses qdev.id for the device tree node name, however
>> we can't rely on the user specifiying the id using proper device tree
>> syntax, ie. address@hidden So separate the device tree node name from the
>> qdev.id, but use the same syntax, so they will match by default.
>> 
>> Signed-off-by: Michael Ellerman <address@hidden>
> 
> This is again a bugfix which I hope will go into 1.0.

Me too. Queued for 1.0.

Btw, next time please put your sob on it as well.


Alex