[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 27/58] device tree: dont fail operations
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PATCH 27/58] device tree: dont fail operations |
Date: |
Wed, 14 Sep 2011 10:42:51 +0200 |
When we screw up and issue an FDT command that doesn't work, we really need to
know immediately and usually can't continue to create the machine. To make sure
we don't need to add error checking in all device tree modification code users,
we can just add the fail checks to the qemu abstract functions.
Signed-off-by: Alexander Graf <address@hidden>
---
device_tree.c | 76 ++++++++++++++++++++++++++++++++++++++------------------
1 files changed, 51 insertions(+), 25 deletions(-)
diff --git a/device_tree.c b/device_tree.c
index f4a78c8..751538e 100644
--- a/device_tree.c
+++ b/device_tree.c
@@ -72,56 +72,81 @@ fail:
return NULL;
}
-int qemu_devtree_setprop(void *fdt, const char *node_path,
- const char *property, void *val_array, int size)
+static int findnode_nofail(void *fdt, const char *node_path)
{
int offset;
offset = fdt_path_offset(fdt, node_path);
- if (offset < 0)
- return offset;
+ if (offset < 0) {
+ fprintf(stderr, "%s Couldn't find node %s: %s\n", __func__, node_path,
+ fdt_strerror(offset));
+ exit(1);
+ }
+
+ return offset;
+}
+
+int qemu_devtree_setprop(void *fdt, const char *node_path,
+ const char *property, void *val_array, int size)
+{
+ int r;
+
+ r = fdt_setprop(fdt, findnode_nofail(fdt, node_path), property, val_array,
size);
+ if (r < 0) {
+ fprintf(stderr, "%s: Couldn't set %s/%s: %s\n", __func__, node_path,
+ property, fdt_strerror(r));
+ exit(1);
+ }
- return fdt_setprop(fdt, offset, property, val_array, size);
+ return r;
}
int qemu_devtree_setprop_cell(void *fdt, const char *node_path,
const char *property, uint32_t val)
{
- int offset;
+ int r;
- offset = fdt_path_offset(fdt, node_path);
- if (offset < 0)
- return offset;
+ r = fdt_setprop_cell(fdt, findnode_nofail(fdt, node_path), property, val);
+ if (r < 0) {
+ fprintf(stderr, "%s: Couldn't set %s/%s = %#08x: %s\n", __func__,
+ node_path, property, val, fdt_strerror(r));
+ exit(1);
+ }
- return fdt_setprop_cell(fdt, offset, property, val);
+ return r;
}
int qemu_devtree_setprop_string(void *fdt, const char *node_path,
const char *property, const char *string)
{
- int offset;
+ int r;
- offset = fdt_path_offset(fdt, node_path);
- if (offset < 0)
- return offset;
+ r = fdt_setprop_string(fdt, findnode_nofail(fdt, node_path), property,
string);
+ if (r < 0) {
+ fprintf(stderr, "%s: Couldn't set %s/%s = %s: %s\n", __func__,
+ node_path, property, string, fdt_strerror(r));
+ exit(1);
+ }
- return fdt_setprop_string(fdt, offset, property, string);
+ return r;
}
int qemu_devtree_nop_node(void *fdt, const char *node_path)
{
- int offset;
+ int r;
- offset = fdt_path_offset(fdt, node_path);
- if (offset < 0)
- return offset;
+ r = fdt_nop_node(fdt, findnode_nofail(fdt, node_path));
+ if (r < 0) {
+ fprintf(stderr, "%s: Couldn't nop node %s: %s\n", __func__, node_path,
+ fdt_strerror(r));
+ exit(1);
+ }
- return fdt_nop_node(fdt, offset);
+ return r;
}
int qemu_devtree_add_subnode(void *fdt, const char *name)
{
- int offset;
char *dupname = g_strdup(name);
char *basename = strrchr(dupname, '/');
int retval;
@@ -133,12 +158,13 @@ int qemu_devtree_add_subnode(void *fdt, const char *name)
basename[0] = '\0';
basename++;
- offset = fdt_path_offset(fdt, dupname);
- if (offset < 0) {
- return offset;
+ retval = fdt_add_subnode(fdt, findnode_nofail(fdt, dupname), basename);
+ if (retval < 0) {
+ fprintf(stderr, "FDT: Failed to create subnode %s: %s\n", name,
+ fdt_strerror(retval));
+ exit(1);
}
- retval = fdt_add_subnode(fdt, offset, basename);
g_free(dupname);
return retval;
}
--
1.6.0.2
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code, (continued)
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 24/58] PPC: E500: Add PV spinning code, Blue Swirl, 2011/09/27
- Re: [Qemu-ppc] [PATCH 24/58] PPC: E500: Add PV spinning code, Alexander Graf, 2011/09/27
- Re: [Qemu-ppc] [PATCH 24/58] PPC: E500: Add PV spinning code, Blue Swirl, 2011/09/27
- Re: [Qemu-ppc] [PATCH 24/58] PPC: E500: Add PV spinning code, Alexander Graf, 2011/09/27
- Re: [Qemu-ppc] [PATCH 24/58] PPC: E500: Add PV spinning code, Blue Swirl, 2011/09/27
- Re: [Qemu-ppc] [PATCH 24/58] PPC: E500: Add PV spinning code, Alexander Graf, 2011/09/28
- Re: [Qemu-ppc] [PATCH 24/58] PPC: E500: Add PV spinning code, Scott Wood, 2011/09/27
- Re: [Qemu-ppc] [PATCH 24/58] PPC: E500: Add PV spinning code, Blue Swirl, 2011/09/27
[Qemu-ppc] [PATCH 53/58] openpic: Unfold read_IRQreg, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 02/58] spapr: prepare for qdevification of irq, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 27/58] device tree: dont fail operations,
Alexander Graf <=
[Qemu-ppc] [PATCH 58/58] KVM: Update kernel headers, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 40/58] PPC: Fix sync instructions problem in SMP, Alexander Graf, 2011/09/14
[Qemu-ppc] [PATCH 01/58] spapr: proper qdevification, Alexander Graf, 2011/09/14
- Re: [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification, David Gibson, 2011/09/14
- Re: [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification, Paolo Bonzini, 2011/09/15
- Re: [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification, David Gibson, 2011/09/15
- Re: [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification, Paolo Bonzini, 2011/09/16
- Re: [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification, Thomas Huth, 2011/09/16
- Re: [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification, Paolo Bonzini, 2011/09/16
- Re: [Qemu-ppc] [PATCH 01/58] spapr: proper qdevification, Benjamin Herrenschmidt, 2011/09/16