Re: target/i386: fix pushed value of EFLAGS.RF

[Jakob Bohm]

On 2024-06-11 00:44, Paolo Bonzini wrote:
> On Tue, Jun 11, 2024 at 12:39 AM Robert Henry <rrh.henry@gmail.com> wrote:
> > Paolo:
> >
> > Regarding your commit to QEMU 
> > https://github.com/qemu/qemu/commit/69cb498c56263a5ae484fd4fef920d3d3eea04c8
> >
> > Four years ago I reported a bug 
> > https://gitlab.com/qemu-project/qemu/-/issues/249 and as part of cleaning up 
> > prior to retirement, I want to get my patch published.
> Oh, thanks for pointing that issue out. I'm happy to help.
>
> I see that your patch has the issue that it doesn't affect PUSHL_RA/POPL_RA.
>
> Also, can you confirm that this is needed:
>
> +  if (/*old_semantics ||*/ cpl == 0) {
> +    val = cpu_ldq_kernel_ra(env, *sp, ra);
> +  } else {
> +    val = cpu_ldq_data_ra(env, *sp, ra);
> +  }
>
> and you cannot just use "val = cpu_ldq_data_ra(env, *sp, ra)"?
Looking at that code, does this imply that Qemu fails to emulate Ring 1 
and 2
of the x86 architecture?

Enjoy

Jakob
--
Jakob Bohm, CIO, Partner, WiseMo A/S.  https://www.wisemo.com
Transformervej 29, 2860 Søborg, Denmark.  Direct +45 31 13 16 10
This public discussion message is non-binding and may contain errors.
WiseMo - Remote Service Management for PCs, Phones and Embedded