[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/36] hw/mips/loongson3_virt: Have fw_conf_init() access local lo
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 04/36] hw/mips/loongson3_virt: Have fw_conf_init() access local loaderparams |
Date: |
Fri, 31 Jan 2025 22:04:47 +0100 |
'loaderparams' is declared statically. Let fw_conf_init()
access its 'cpu_freq' and 'ram_size' fields.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20250115232952.31166-4-philmd@linaro.org>
---
hw/mips/loongson3_virt.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c
index 28d4eaf1e59..45a524cca89 100644
--- a/hw/mips/loongson3_virt.c
+++ b/hw/mips/loongson3_virt.c
@@ -280,7 +280,7 @@ static void fw_cfg_boot_set(void *opaque, const char
*boot_device,
fw_cfg_modify_i16(opaque, FW_CFG_BOOT_DEVICE, boot_device[0]);
}
-static void fw_conf_init(unsigned long ram_size)
+static void fw_conf_init(void)
{
static const uint8_t suspend[6] = {128, 0, 0, 129, 128, 128};
FWCfgState *fw_cfg;
@@ -289,9 +289,9 @@ static void fw_conf_init(unsigned long ram_size)
fw_cfg = fw_cfg_init_mem_wide(cfg_addr, cfg_addr + 8, 8, 0, NULL);
fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS,
(uint16_t)current_machine->smp.cpus);
fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS,
(uint16_t)current_machine->smp.max_cpus);
- fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)ram_size);
+ fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, loaderparams.ram_size);
fw_cfg_add_i32(fw_cfg, FW_CFG_MACHINE_VERSION, 1);
- fw_cfg_add_i64(fw_cfg, FW_CFG_CPU_FREQ, get_cpu_freq_hz());
+ fw_cfg_add_i64(fw_cfg, FW_CFG_CPU_FREQ, loaderparams.cpu_freq);
fw_cfg_add_file(fw_cfg, "etc/system-states",
g_memdup2(suspend, sizeof(suspend)), sizeof(suspend));
@@ -633,9 +633,9 @@ static void mips_loongson3_virt_init(MachineState *machine)
* Please use -L to set the BIOS path and -bios to set bios name.
*/
+ loaderparams.cpu_freq = get_cpu_freq_hz();
+ loaderparams.ram_size = ram_size;
if (kernel_filename) {
- loaderparams.cpu_freq = get_cpu_freq_hz();
- loaderparams.ram_size = ram_size;
loaderparams.kernel_filename = kernel_filename;
loaderparams.kernel_cmdline = kernel_cmdline;
loaderparams.initrd_filename = initrd_filename;
@@ -661,7 +661,7 @@ static void mips_loongson3_virt_init(MachineState *machine)
exit(1);
}
- fw_conf_init(ram_size);
+ fw_conf_init();
}
loongson3_virt_devices_init(machine, liointc);
--
2.47.1
- [PULL 00/36] Misc HW patches for 2025-01-31, Philippe Mathieu-Daudé, 2025/01/31
- [PULL 01/36] hw/rx/rx-gdbsim: Remove unnecessary uses of &first_cpu, Philippe Mathieu-Daudé, 2025/01/31
- [PULL 02/36] hw/mips/loongson3_virt: Factor generic_cpu_reset() out, Philippe Mathieu-Daudé, 2025/01/31
- [PULL 03/36] hw/mips/loongson3_virt: Invert vCPU creation order to remove &first_cpu, Philippe Mathieu-Daudé, 2025/01/31
- [PULL 04/36] hw/mips/loongson3_virt: Have fw_conf_init() access local loaderparams,
Philippe Mathieu-Daudé <=
- [PULL 05/36] hw/mips/loongson3_virt: Pass CPU argument to get_cpu_freq_hz(), Philippe Mathieu-Daudé, 2025/01/31
- [PULL 06/36] hw/mips/loongson3_bootp: Include missing headers, Philippe Mathieu-Daudé, 2025/01/31
- [PULL 07/36] hw/mips/loongson3: Propagate cpu_count to init_loongson_params(), Philippe Mathieu-Daudé, 2025/01/31
- [PULL 08/36] hw/mips/loongson3_virt: Propagate cpu_count to init_boot_param(), Philippe Mathieu-Daudé, 2025/01/31
- [PULL 09/36] hw/mips/loongson3_bootp: Propagate processor_id to init_cpu_info(), Philippe Mathieu-Daudé, 2025/01/31
- [PULL 10/36] hw/mips/loongson3_virt: Propagate processor_id to init_loongson_params(), Philippe Mathieu-Daudé, 2025/01/31
- [PULL 11/36] hw/mips/loongson3_virt: Propagate %processor_id to init_boot_param(), Philippe Mathieu-Daudé, 2025/01/31
- [PULL 12/36] hw/mips/loongson3_bootp: Move to common_ss[], Philippe Mathieu-Daudé, 2025/01/31
- [PULL 13/36] hw/irq: Introduce qemu_init_irqs() helper, Philippe Mathieu-Daudé, 2025/01/31
- [PULL 14/36] hw/ipack: Clarify KConfig symbols, Philippe Mathieu-Daudé, 2025/01/31