qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/11] hw/sd/omap_mmc: Do a minimal conversion to QDev


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 01/11] hw/sd/omap_mmc: Do a minimal conversion to QDev
Date: Thu, 30 Jan 2025 23:30:07 +0100
User-agent: Mozilla Thunderbird

On 28/1/25 11:45, Peter Maydell wrote:
Do a minimal conversion of the omap_mmc device model to QDev.

In this commit we do the bare minimum to produce a working device:
  * add the SysBusDevice parent_obj and the usual type boilerplate
  * omap_mmc_init() now returns a DeviceState*
  * reset is handled by sysbus reset, so the SoC reset function
    doesn't need to call omap_mmc_reset() any more
  * code that should obviously be in init/realize is moved there
    from omap_mmc_init()

We leave various pieces of cleanup to later commits:
  * rationalizing 'struct omap_mmc_s *' to 'OMAPMMCState *'
  * using gpio lines rather than having omap_mmc_init() directly
    set s->irq, s->dma
  * switching away from the legacy SD API and instead having
    the SD card plugged into a bus

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
  include/hw/arm/omap.h | 15 ++++----
  hw/arm/omap1.c        |  1 -
  hw/sd/omap_mmc.c      | 83 +++++++++++++++++++++++++++++++++++--------
  3 files changed, 76 insertions(+), 23 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]