[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/15] block: Allow inactivating already inactive nodes
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 05/15] block: Allow inactivating already inactive nodes |
Date: |
Thu, 30 Jan 2025 14:09:30 -0600 |
User-agent: |
NeoMutt/20250113 |
On Thu, Jan 30, 2025 at 06:12:36PM +0100, Kevin Wolf wrote:
> What we wanted to catch with the assertion is cases where the recursion
> finds that a child was inactive before its parent. This should never
> happen. But if the user tries to inactivate an image that is already
> inactive, that's harmless and we don't want to fail the assertion.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- Re: [PATCH v2 01/15] block: Add 'active' field to BlockDeviceInfo, (continued)
- [PATCH v2 02/15] block: Inactivate external snapshot overlays when necessary, Kevin Wolf, 2025/01/30
- [PATCH v2 03/15] migration/block-active: Remove global active flag, Kevin Wolf, 2025/01/30
- [PATCH v2 04/15] block: Don't attach inactive child to active node, Kevin Wolf, 2025/01/30
- [PATCH v2 06/15] block: Fix crash on block_resize on inactive node, Kevin Wolf, 2025/01/30
- [PATCH v2 05/15] block: Allow inactivating already inactive nodes, Kevin Wolf, 2025/01/30
- Re: [PATCH v2 05/15] block: Allow inactivating already inactive nodes,
Eric Blake <=
- [PATCH v2 07/15] block: Add option to create inactive nodes, Kevin Wolf, 2025/01/30
- [PATCH v2 08/15] block: Add blockdev-set-active QMP command, Kevin Wolf, 2025/01/30
- [PATCH v2 09/15] block: Support inactive nodes in blk_insert_bs(), Kevin Wolf, 2025/01/30