Re: [PULL 8/9] target/hppa: Implement space register hashing for 64-bit HP-UX

[Michael Tokarev]

30.01.2025 16:29, deller@kernel.org wrote:

> diff --git a/target/hppa/translate.c b/target/hppa/translate.c

> +    if (ctx->is_pa20 && (a->dr == 2)) {
> +        /* Update gva_offset_mask from the new value of %dr2 */
> +        gen_helper_update_gva_offset_mask(tcg_env);
> +        /* Exit to capture the new value for the next TB. */
> +        ctx->base.is_jmp = DISAS_IAQ_N_STALE_EXIT;
> +    }

This fails to build, it looks like:

https://gitlab.com/qemu-project/qemu/-/jobs/8998524001 (and many others),

../target/hppa/translate.c:4621:9: error: implicit declaration of function 'gen_helper_update_gva_offset_mask'; did you mean 'update_gva_offset_mask'? 
[-Werror=implicit-function-declaration]
 4621 |         gen_helper_update_gva_offset_mask(tcg_env);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         update_gva_offset_mask
../target/hppa/translate.c:4621:9: error: nested extern declaration of 
'gen_helper_update_gva_offset_mask' [-Werror=nested-externs]
cc1: all warnings being treated as errors