[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/9] block: Allow inactivating already inactive nodes
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/9] block: Allow inactivating already inactive nodes |
Date: |
Thu, 30 Jan 2025 12:49:53 -0600 |
User-agent: |
NeoMutt/20250113 |
On Wed, Jan 22, 2025 at 12:50:38PM +0100, Kevin Wolf wrote:
> What we wanted to catch with the assertion is cases where the recursion
> finds that a child was inactive before its parent. This should never
> happen. But if the user tries to inactivate an image that is already
> inactive, that's harmless and we don't want to fail the assertion.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- Re: [PATCH 4/9] block/export: Don't ignore image activation error in blk_exp_add(), (continued)
- [PATCH 3/9] block: Support inactive nodes in blk_insert_bs(), Kevin Wolf, 2025/01/22
- [PATCH 2/9] block: Add option to create inactive nodes, Kevin Wolf, 2025/01/22
- [PATCH 6/9] nbd/server: Support inactive nodes, Kevin Wolf, 2025/01/22
- [PATCH 7/9] block: Add blockdev-set-active QMP command, Kevin Wolf, 2025/01/22
- [PATCH 8/9] iotests: Add filter_qtest(), Kevin Wolf, 2025/01/22
- [PATCH 9/9] iotests: Add qsd-migrate case, Kevin Wolf, 2025/01/22
- [PATCH 1/9] block: Allow inactivating already inactive nodes, Kevin Wolf, 2025/01/22
- Re: [PATCH 1/9] block: Allow inactivating already inactive nodes,
Eric Blake <=
- [PATCH 5/9] block/export: Add option to allow export of inactive nodes, Kevin Wolf, 2025/01/22
- Re: [PATCH 0/9] block: Managing inactive nodes (QSD migration), Eric Blake, 2025/01/30