Re: [PATCH v3] net/slirp: libslirp 4.8.0 compatibility

[Michael Tokarev]

30.01.2025 15:21, Thomas Huth wrote:
> On 30/01/2025 12.48, Michael Tokarev wrote:

> > +#if !SLIRP_CHECK_VERSION(4,8,0)
> > +# define slirp_os_socket int
> > +# define slirp_pollfds_fill_socket slirp_pollfds_fill
> > +# define register_poll_socket register_poll_fd
>
> If I get that right, register_poll_socket has just been added to libslirp 4.9.0, but is not available with 4.8.0 yet? ... so you might need to split 
> the #if into two parts, one for 4.8.0 and one for 4.9.0 ?

Nope.  It all should be 4.9.0, not 4.8.0.  It is yet another result of
me doing things in ENOCOFFEE (or ETOOMUCHCOFFEE) mode today (I had
almost no sleep tonight due to other issues needing my attention).

I verified the code 4.7.x and the newly released 4.9.0, but not 4.8.x.
But it will fail with 4.8.x because the new fields aren't present there.

It should be SLIRP_CHECK_VERSION(4,9,0), that's all.

/mjt