Re: [PATCH] net/slirp: introduce slirp_os_socket to stay compatible with libslirp past 4.8.0

[Michael Tokarev]

30.01.2025 13:09, Thomas Huth wrote:
> On 30/01/2025 03.13, Samuel Thibault wrote:
> > Hello,
> >
> > Samuel Thibault, le jeu. 10 oct. 2024 01:06:47 +0200, a ecrit:
> > > Michael Tokarev, le sam. 05 oct. 2024 10:07:53 +0300, a ecrit:
> > > > libslirp introduced new typedef after 4.8.0, slirp_os_socket, which
> > > > is defined to SOCKET on windows, which, in turn, is a 64bit number.
> > > > qemu uses int, so callback function prorotypes changed.
> > >
> > > I have fixed the code in upstream libslirp, to avoid breaking the API
> > > and ABI, and instead provide new functions & methods so that
> > > qemu/libslirp can upgrade smoothly.
> >
> > It is now released in version 4.9.0 of libslirp.
>
> Seems like 4.9.0 breaks the CI:
>
> https://gitlab.com/thuth/qemu/-/jobs/8994301595#L4373

Yes, it's because the old method used by qemu is now deprecated,
and we build with -Werror.

The prob here is that apparently we don't have a good way to use
slirp on win64.  Because the new slirp callback uses SOCKET type
instead of int, and SOCKET is 64bit on win64, and qemu main loop
is based on GPollFD which uses int.

/mjt