Re: [PATCH] tests/functional: Extend PPC 40p test with Linux boot

[Thomas Huth]

On 29/01/2025 11.22, Cédric Le Goater wrote:
> Fetch the cdrom image for the IBM 6015 PReP PowerPC machine hosted on
> the Juneau Linux Users Group site, boot and check Linux version.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   tests/functional/test_ppc_40p.py | 20 +++++++++++++++++++-
>   1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/tests/functional/test_ppc_40p.py b/tests/functional/test_ppc_40p.py
> index 7a74e0cca70b..5ce79aec5e6b 100755
> --- a/tests/functional/test_ppc_40p.py
> +++ b/tests/functional/test_ppc_40p.py
> @@ -9,7 +9,7 @@
>   
>   from qemu_test import QemuSystemTest, Asset
>   from qemu_test import wait_for_console_pattern, skipUntrustedTest
> -
> +from qemu_test import exec_command_and_wait_for_pattern
>   

Please keep 2 empty lines between the imports and the class statements 
(Daniel recently tried to standardize on this coding style)

>   class IbmPrep40pMachine(QemuSystemTest):
>   
> @@ -72,5 +72,23 @@ def test_openbios_and_netbsd(self):
>           self.vm.launch()
>           wait_for_console_pattern(self, 'NetBSD/prep BOOT, Revision 1.9')
>   
> +    ASSET_40P_SANDALFOOT = Asset(
> +        'http://www.juneau-lug.org/zImage.initrd.sandalfoot',
> +        '749ab02f576c6dc8f33b9fb022ecb44bf6a35a0472f2ea6a5e9956bc15933901')
> +
> +    def test_openbios_and_linux(self):
> +        self.set_machine('40p')
> +        self.require_accelerator("tcg")
> +        drive_path = self.ASSET_40P_SANDALFOOT.fetch()
> +        self.vm.set_console()
> +        self.vm.add_args('-cdrom', drive_path,
> +                         '-boot', 'd')
> +
> +        self.vm.launch()
> +        wait_for_console_pattern(self, 'Please press Enter to activate this 
> console.')
> +        exec_command_and_wait_for_pattern(self, '\012', '#')
> +        exec_command_and_wait_for_pattern(self, 'uname -a', 'Linux ppc 2.4.18')
> +        exec_command_and_wait_for_pattern(self, 'poweroff', 'Terminated')
> +
>   if __name__ == '__main__':
>       QemuSystemTest.main()

With the nit fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>