Re: [PATCH] tests/functional: Add a ppc64 mac99 test

[Cédric Le Goater]

> > > > +        self.vm.set_console()
> > > > +
> > > > +        self.vm.add_args('-kernel', linux_path,
> > > > +                         '-append', 'root=/dev/sda',
> > > > +                         '-drive', f'file={rootfs_path},format=raw',
> > > > +                         '-net', 'nic,model=sungem', '-net', 'user',
>
> The machine already has a default sungem NIC so maybe you can omit that too. 

Yes. It works well without it. Will remove the nic.

> The user network used to be the default so even that may not be needed but I'm 
> not sure if that's still the case since libslirp was moved out. Wasn't the 
> preferred option -netdev user nowadays and -device for the card?
>
> > > > +                         '-snapshot', '-nographic')
> > >
> > > I just also noticed that we already have "-display none" in 
> > > python/qemu/machine/machine.py, so you likely don't need the -nographic here (but looks 
> > > like we've got that wrong in a bunch of tests already).
> >
> > I think we need -nographic else OpenBIOS crashes.  I will check.
>
> It should not crash 

It doesn't crash indeed, but it complains :

  2025-01-28 21:55:24,498: >> CPU type PowerPC,970FX
  2025-01-28 21:55:24,501: milliseconds isn't unique.
  2025-01-28 21:55:24,540: Output device screen not found.
  2025-01-28 21:55:24,545: Output device screen not found.
  2025-01-28 21:55:24,548: >> [ppc] Kernel already loaded (0x01000000 + 
0x014a8b58) (initrd 0x00000000 + 0x00000000)
  2025-01-28 21:55:24,548: >> [ppc] Kernel command line: root=/dev/sda
  2025-01-28 21:55:24,560: >> switching to new context:
  2025-01-28 21:55:24,567: NULL ihandle
  2025-01-28 21:55:24,567: Unexpected client interface exception: -2

and there is no console ouput. With -nographic :

  2025-01-28 22:19:42,938: >> CPU type PowerPC,970FX
  2025-01-28 22:19:42,941: milliseconds isn't unique.
  2025-01-28 22:19:42,993: Welcome to OpenBIOS v1.1 built on Sep 24 2024 19:56
  2025-01-28 22:19:42,997: >> [ppc] Kernel already loaded (0x01000000 + 
0x014a8b58) (initrd 0x00000000 + 0x00000000)
  2025-01-28 22:19:42,997: >> [ppc] Kernel command line: root=/dev/sda
  2025-01-28 22:19:43,010: >> switching to new context:
  2025-01-28 22:19:43,018: OF stdout device is: 
/pci@f0000000/mac-io@c/escc@13000/ch-a@13020


> but maybe it displays then on the graphics output so you won't get the needed feedback on serial? Although -append 'console=tty<whatever it's called on that machine>' might fix that. 

Nope.

> But using -nographic makes sense for a serial only test.

I will keep -nographic  for this test.

Thanks,
C.