Re: [PATCH 7/7] tests/qtest/migration: Allow using accelerators different of TCG / KVM

[Fabiano Rosas]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> There is no particular reason to restrict all the framework
> to TCG or KVM, since we can check on a per-test basis which
> accelerator is available (via MigrationTestEnv::has_$ACCEL).

The reason is:

CONFIG_KVM=n
CONFIG_TCG=n

The check is about "there is no accelerator at all".

>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  tests/qtest/migration/framework.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/tests/qtest/migration/framework.c 
> b/tests/qtest/migration/framework.c
> index 30808de14e0..e5f0712c266 100644
> --- a/tests/qtest/migration/framework.c
> +++ b/tests/qtest/migration/framework.c
> @@ -950,11 +950,6 @@ MigrationTestEnv *migration_get_env(void)
>      env->has_hvf = qtest_has_accel("hvf");
>      env->has_tcg = qtest_has_accel("tcg");
>  
> -    if (!env->has_tcg && !env->has_kvm) {
> -        g_test_skip("No KVM or TCG accelerator available");
> -        return env;
> -    }
> -
>      env->has_dirty_ring = env->has_kvm && kvm_dirty_ring_supported();
>      env->has_uffd = ufd_version_check(&env->uffd_feature_thread_id);
>      env->is_x86 = !strcmp(env->arch, "i386") || !strcmp(env->arch, "x86_64");