Re: [PATCH 1/7] migration/dirtyrate: Do not unlock cpu_list lock twice

[Fabiano Rosas]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> &qemu_cpu_list_lock is locked within the WITH_QEMU_LOCK_GUARD()
> context, then unlocked. No need to manually unlock it.
>
> Fixes: 370ed600296 ("cpu: expose qemu_cpu_list_lock for lock-guard use")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  migration/dirtyrate.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 7c955894e47..4b94dd7c500 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -174,7 +174,6 @@ retry:
>          if (gen_id != cpu_list_generation_id_get()) {
>              g_free(records);
>              g_free(stat->rates);
> -            cpu_list_unlock();
>              goto retry;
>          }
>          vcpu_dirty_stat_collect(records, false);

Reviewed-by: Fabiano Rosas <farosas@suse.de>