[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Stable-9.1.3 49/58] multifd: bugfix for incorrect migration data with Q
From: |
Michael Tokarev |
Subject: |
[Stable-9.1.3 49/58] multifd: bugfix for incorrect migration data with QPL compression |
Date: |
Mon, 27 Jan 2025 23:25:35 +0300 |
When QPL compression is enabled on the migration channel and the same
dirty page changes from a normal page to a zero page in the iterative
memory copy, the dirty page will not be updated to a zero page again
on the target side, resulting in incorrect memory data on the source
and target sides.
The root cause is that the target side does not record the normal pages
to the receivedmap.
The solution is to add ramblock_recv_bitmap_set_offset in target side
to record the normal pages.
Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
Reviewed-by: Jason Zeng <jason.zeng@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20241218091413.140396-3-yuan1.liu@intel.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
(cherry picked from commit 2588a5f99b0c3493b4690e3ff01ed36f80e830cc)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
diff --git a/migration/multifd-qpl.c b/migration/multifd-qpl.c
index 9265098ee7..fea60e3937 100644
--- a/migration/multifd-qpl.c
+++ b/migration/multifd-qpl.c
@@ -730,6 +730,7 @@ static int multifd_qpl_recv(MultiFDRecvParams *p, Error
**errp)
qpl->zlen[i] = be32_to_cpu(qpl->zlen[i]);
assert(qpl->zlen[i] <= p->page_size);
zbuf_len += qpl->zlen[i];
+ ramblock_recv_bitmap_set_offset(p->block, p->normal[i]);
}
/* read compressed pages */
--
2.39.5
- [Stable-9.1.3 37/58] config/targets: update aarch64_be-linux-user gdb XML list, (continued)
- [Stable-9.1.3 37/58] config/targets: update aarch64_be-linux-user gdb XML list, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 39/58] docs: Correct release of TCG trace-events removal, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 23/58] hw/openrisc/openrisc_sim: keep serial@90000000 as default, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 41/58] migration: Add more error handling to analyze-migration.py, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 36/58] s390x/s390-virtio-ccw: don't crash on weird RAM sizes, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 42/58] migration: Remove unused argument in vmsd_desc_field_end, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 44/58] s390x: Fix CSS migration, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 45/58] migration: Rename vmstate_info_nullptr, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 46/58] migration: Dump correct JSON format for nullptr replacement, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 47/58] migration: Fix arrays of pointers in JSON writer, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 49/58] multifd: bugfix for incorrect migration data with QPL compression,
Michael Tokarev <=
- [Stable-9.1.3 50/58] tests/qtest/boot-serial-test: Correct HPPA machine name, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 38/58] target/loongarch: Use actual operand size with vbsrl check, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 48/58] multifd: bugfix for migration using compression methods, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 53/58] pci: ensure valid link status bits for downstream ports, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 51/58] backends/cryptodev-vhost-user: Fix local_error leaks, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 52/58] hw/usb/hcd-xhci-pci: Use modulo to select MSI vector as per spec, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 54/58] pci/msix: Fix msix pba read vector poll end calculation, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 55/58] tests: acpi: whitelist expected blobs, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 57/58] tests: acpi: update expected blobs, Michael Tokarev, 2025/01/28
- [Stable-9.1.3 56/58] pci: acpi: Windows 'PCI Label Id' bug workaround, Michael Tokarev, 2025/01/28