Re: [PATCH 3/5] tests/functional/test_mipsel_malta: Convert the mipsel replay tests

[Thomas Huth]

On 24/01/2025 16.36, Daniel P. Berrangé wrote:
> On Fri, Jan 24, 2025 at 03:15:27PM +0100, Thomas Huth wrote:
> > Move the mipsel replay tests from tests/avocado/replay_kernel.py to
> > the functional framework. Since the functional tests should be run per
> > target, we cannot stick all replay tests in one file. Thus let's add
> > these tests to the file where we already use the same asset already.
>
> Are the replay tests liable to impact running time much ?
>
> The test timeouts are per-file, which could motivate
> a separate test_mipsel_malta_replay.py file ?

The mipsel tests take almost 2 minutes on my fast laptop already, so yes, on 
CI and slow systems this will need a higher timeout setting.

> Guess that answers my own question. I'd think a separate
> file for replay tests per target is nicer, so we leave the
> default executed malta tests with short timeout in meson.

Thinking about this twice, it's also nicer for the MAINTAINERS file if we 
have the replay related tests in separate files, so yes, let's go with 
separate files for the replay tests.

 Thomas