Re: [PATCH 7/9] hw/arm/stellaris: Only create MPU when available

[Peter Maydell]

On Fri, 10 Jan 2025 at 16:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  hw/arm/stellaris.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
> index 655bf85e89e..d87587225c2 100644
> --- a/hw/arm/stellaris.c
> +++ b/hw/arm/stellaris.c
> @@ -1128,6 +1128,9 @@ static void stellaris_init(MachineState *ms, 
> stellaris_board_info *board)
>      qdev_prop_set_uint8(nvic, "num-prio-bits", NUM_PRIO_BITS);
>      qdev_prop_set_string(nvic, "cpu-type", ms->cpu_type);
>      qdev_prop_set_bit(nvic, "enable-bitband", true);
> +    if (!DEV_CAP(1, MPU)) {
> +        qdev_prop_set_uint32(nvic, "mpu-ns-regions", 0); /* Disable MPU */
> +    }
>      qdev_connect_clock_in(nvic, "cpuclk",
>                            qdev_get_clock_out(ssys_dev, "SYSCLK"));
>      /* This SoC does not connect the systick reference clock */
> --

This isn't actually a behaviour change, right? Both our
boards set bit 7 in dc1 in their stellaris_board_info array.

With the commit message updated to mention that:

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM