Re: [PATCH 6/6] hw/loader: Pass ELFDATA endian order argument to load_elf()

[BALATON Zoltan]

On Mon, 27 Jan 2025, Philippe Mathieu-Daudé wrote:
> Rather than passing a boolean 'is_big_endian' argument,
> directly pass the ELFDATA, which can be unspecified using
> the ELFDATANONE value.
>
> Update the call sites:
>  0                 -> ELFDATA2LSB
>  1                 -> ELFDATA2MSB
>  TARGET_BIG_ENDIAN -> TARGET_BIG_ENDIAN ? ELFDATA2MSB : ELFDATA2LSB
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

> ---
> Sorry, couldn't find good ways to split this patch...
> ---
> include/hw/loader.h            | 2 +-
> hw/core/loader.c               | 5 ++---
> hw/alpha/dp264.c               | 4 ++--
> hw/hppa/machine.c              | 4 ++--
> hw/i386/multiboot.c            | 4 ++--
> hw/i386/x86-common.c           | 4 ++--
> hw/loongarch/boot.c            | 2 +-
> hw/m68k/an5206.c               | 2 +-
> hw/m68k/mcf5208.c              | 2 +-
> hw/m68k/q800.c                 | 2 +-
> hw/m68k/virt.c                 | 2 +-
> hw/microblaze/boot.c           | 6 ++++--
> hw/mips/boston.c               | 2 +-
> hw/mips/fuloong2e.c            | 2 +-
> hw/mips/loongson3_virt.c       | 2 +-
> hw/mips/malta.c                | 5 +++--
> hw/mips/mipssim.c              | 3 ++-
> hw/openrisc/boot.c             | 2 +-
> hw/pci-host/raven.c            | 4 ++--
> hw/ppc/e500.c                  | 2 +-
> hw/ppc/mac_newworld.c          | 5 +++--
> hw/ppc/mac_oldworld.c          | 4 ++--
> hw/ppc/pegasos2.c              | 8 ++++----
> hw/ppc/ppc405_boards.c         | 2 +-
> hw/ppc/ppc440_bamboo.c         | 3 ++-
> hw/ppc/sam460ex.c              | 2 +-
> hw/ppc/spapr.c                 | 8 ++++----
> hw/ppc/virtex_ml507.c          | 4 ++--
> hw/s390x/ipl.c                 | 6 +++---
> hw/sparc/leon3.c               | 2 +-
> hw/sparc/sun4m.c               | 5 +++--
> hw/sparc64/sun4u.c             | 6 +++---
> hw/tricore/triboard.c          | 2 +-
> hw/tricore/tricore_testboard.c | 2 +-
> hw/xtensa/sim.c                | 3 ++-
> hw/xtensa/xtfpga.c             | 3 ++-
> 36 files changed, 67 insertions(+), 59 deletions(-)